fix: date formatting used when saving snapshot files #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a date formatting issue in the snapshot file naming functionality. The DateTime format string was using lowercase 'mm' for months instead of uppercase 'MM', which would have resulted in minutes being used twice in the filename.
- Corrected DateTime format string to properly represent months instead of minutes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
United600
changed the title
dosubot
bot
added
size:XS
huynhsontung
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the file naming logic when saving snapshots in the media player controls. The main change corrects the timestamp format used in the filename to ensure dates are saved in the proper format.
PlayerControlsViewModel.cs, the file naming pattern inSaveSnapshotInternalAsyncnow usesDateTimeOffset.Now:yyyyMMdd_HHmmssinstead ofDateTime.Now:yyyymmdd_HHmmss, fixing the date format and ensuring the filename reflects the correct date and time.